Skip to content

Fix/dupe state #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryceknz merged 5 commits into from
May 19, 2026
+10 −1
Merged

Fix/dupe state #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f0014cf
fix: remove duplicate state
fant0mex May 15, 2024
14f2eab
Create cuddly-rules-behave.md
fant0mex May 15, 2024
9278faa
Merge remote-tracking branch 'origin/main' into local/fix-dupe-state-…
bryceknz May 18, 2026
c6c6b02
fix(ios): avoid duplicate auth nonce parameter
bryceknz May 18, 2026
e838d7d
changeset: patch duplicate iOS auth parameters
bryceknz May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cuddly-rules-behave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'react-native-app-auth': patch
---

Remove duplicate iOS auth `state` and `nonce` parameters.
6 changes: 5 additions & 1 deletion packages/react-native-app-auth/ios/RNAppAuth.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,10 @@ - (void)authorizeWithConfiguration: (OIDServiceConfiguration *) configuration
NSString *codeVerifier = usePKCE ? [[self class] generateCodeVerifier] : nil;
NSString *codeChallenge = usePKCE ? [[self class] codeChallengeS256ForVerifier:codeVerifier] : nil;
NSString *nonce = useNonce ? additionalParameters[@"nonce"]? additionalParameters[@"nonce"]: [[self class] generateState] : nil ;

NSMutableDictionary* mutableDict = [additionalParameters mutableCopy];
[mutableDict removeObjectForKey:@"state"];
[mutableDict removeObjectForKey:@"nonce"];

// builds authentication request
OIDAuthorizationRequest *request =
Expand All @@ -353,7 +357,7 @@ - (void)authorizeWithConfiguration: (OIDServiceConfiguration *) configuration
codeVerifier:codeVerifier
codeChallenge:codeChallenge
codeChallengeMethod: usePKCE ? OIDOAuthorizationRequestCodeChallengeMethodS256 : nil
additionalParameters:additionalParameters];
additionalParameters:[mutableDict copy]];

// performs authentication request
id<UIApplicationDelegate, RNAppAuthAuthorizationFlowManager> appDelegate = (id<UIApplicationDelegate, RNAppAuthAuthorizationFlowManager>)[UIApplication sharedApplication].delegate;
Expand Down
Loading