Repository navigation
Framework Wireless Touchpad Keyboard Boards - #2
Open
JohnAZoidberg wants to merge 4 commits into
Open
JohnAZoidberg wants to merge 4 commits into
JohnAZoidberg wants to merge 4 commits into
Conversation
The USBHS wrapper driver tracks VBUS state with a k_event, but its Kconfig option does not select EVENTS. Any configuration that enables the wrapper without some other option selecting EVENTS fails to link with undefined references to z_impl_k_event_init(), z_impl_k_event_post() and z_impl_k_event_set_masked(). The default nrf54lm20dk configuration hides this because REGULATOR is off, so the wrapper is not built. Building samples/basic/blinky for nrf54lm20dk/nrf54lm20a/cpuapp with CONFIG_REGULATOR=y reproduces the link failure; with this change it links. Tested on nRF54LM20 hardware. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Build tested with: samples/hello_world (linked for the MCUboot application slot) samples/subsys/usb/cdc_acm Signed-off-by: Daniel Schaefer <dhs@frame.work>
Build tested with: samples/basic/blinky (linked for the MCUboot application slot) samples/basic/blinky_pwm samples/subsys/usb/hid-keyboard Signed-off-by: Daniel Schaefer <dhs@frame.work>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @JohnAZoidberg, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
Signed-off-by: Daniel Schaefer <dhs@frame.work>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP PR here before upstreaming it.