Optional PRIVILEGED_DATA wrapper + Partner-Supported-Ports submodule update - #1433
Conversation
|
|
@AniruddhaKanhere any chance you can review, or point this PR to the appropriate reviewer(s)? Thanks in advance. |
|
Instead of adding a new config, how about changing this block to the following: #ifndef PRIVILEGED_FUNCTION
#define PRIVILEGED_FUNCTION
#endif
#ifndef PRIVILEGED_DATA
#define PRIVILEGED_DATA
#endif
#ifndef FREERTOS_SYSTEM_CALL
#define FREERTOS_SYSTEM_CALL
#endifThis makes it more generic as ports can override whichever macro they need in portmacro.h. |
|
@aggarg thanks for your suggestion -- it is cleaner and more flexible than my original proposal. I should be able to make this work, although I will need to rearrange some include file ordering within the Xtensa port. I will do some testing and submit a PR to the submodule before updating this PR. Separately, I'm assuming that updating the pointer to the Partner-Supported-Ports submodule through a PR like this is acceptable, but please LMK if there's a preferred procedure. |
Yes, this is totally acceptable. |
|
@aggarg updated PR with the changes you proposed, and bumped Partner-Supported-Ports reference. Ready for review again. Thanks. |
|
@ianstcdns Would you please rebase on top of main? |
- User can define portMOVE_PRIVILEGED_DATA as a section attribute to move the PRIVILEGED_DATA section arbitrarily. - Allows critical data to be placed in port-specific location for improved performance, notably for cache-coherent SMP. - Does not require enabling the full MPU wrappers. Signed-off-by: Ian Thompson <ianst@cadence.com>
- Instead, when MPU wrappers are not used, allow port to override PRIVILEGED_FUNCTION, PRIVILEGED_DATA, or FREERTOS_SYSTEM_CALL selectively, permitting custom section placement at link-time. - Allows critical data to be placed in port-specific location for improved performance, notably for cache-coherent SMP. - Does not require enabling the full MPU wrappers. Signed-off-by: Ian Thompson <ianst@cadence.com>
b84a78c to
a121830
Compare
|
|
@aggarg PR rebased onto main; no other changes. Would it also be helpful if I squash the commits, or is that typically done when merging the PR? Thanks again. |
|
@AniruddhaKanhere @patrzhan any chance you could review? This is a follow-up PR to FreeRTOS/FreeRTOS-Kernel-Partner-Supported-Ports#32 ... thanks in advance |
…update (FreeRTOS#1433) - Instead, when MPU wrappers are not used, allow port to override PRIVILEGED_FUNCTION, PRIVILEGED_DATA, or FREERTOS_SYSTEM_CALL selectively, permitting custom section placement at link-time. - Allows critical data to be placed in port-specific location for improved performance, notably for cache-coherent SMP. - Does not require enabling the full MPU wrappers.
- Instead, when MPU wrappers are not used, allow port to override PRIVILEGED_FUNCTION, PRIVILEGED_DATA, or FREERTOS_SYSTEM_CALL selectively, permitting custom section placement at link-time. - Allows critical data to be placed in port-specific location for improved performance, notably for cache-coherent SMP. - Does not require enabling the full MPU wrappers.
- Instead, when MPU wrappers are not used, allow port to override PRIVILEGED_FUNCTION, PRIVILEGED_DATA, or FREERTOS_SYSTEM_CALL selectively, permitting custom section placement at link-time. - Allows critical data to be placed in port-specific location for improved performance, notably for cache-coherent SMP. - Does not require enabling the full MPU wrappers.
- Instead, when MPU wrappers are not used, allow port to override PRIVILEGED_FUNCTION, PRIVILEGED_DATA, or FREERTOS_SYSTEM_CALL selectively, permitting custom section placement at link-time. - Allows critical data to be placed in port-specific location for improved performance, notably for cache-coherent SMP. - Does not require enabling the full MPU wrappers. Cherry pick + merge required to maintain submodule pointers.
3 participants
Support moving PRIVILEGED_DATA via an optional MPU wrapper:
Increment Partner-Supported-Ports submodule to the latest commit
Passed regression testing with 100+ Xtensa configurations (SMP and single-core)
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.