portable: optimize BaseType_t access for GCC ARM_CM3 - #1487
Open
ys160-boop wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yiming Sun <ys160@rice.edu>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Define
portBASE_TYPE_ENTER_CRITICAL()andportBASE_TYPE_EXIT_CRITICAL()as no-ops for the single-core GCC ARM_CM3 port.BaseType_tandUBaseType_tare 32-bit for this port, and the timer status field accessed by the affected APIs is 8-bit. These accesses can be performed atomically on Cortex-M3, so the affected query APIs do not need to enter a critical section.This removes unnecessary critical-section overhead from the affected queue, task, and timer query APIs while leaving the normal
portENTER_CRITICAL()andportEXIT_CRITICAL()behavior unchanged.Test Steps
queue.c,tasks.c, andtimers.cfor Cortex-M3 usingarm-none-eabi-gccwith-mcpu=cortex-m3 -mthumb -O2.uxQueueMessagesWaiting()uxQueueSpacesAvailable()uxTaskPriorityGet()uxTaskBasePriorityGet()xTimerGetReloadMode()xTimerIsTimerActive()vPortEnterCritical()orvPortExitCritical().git diff --checkwith no errors.Checklist:
Related Issue
Contributes to #1059.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.