Repository navigation
Fix: clearing multi-select favorites doesn't persist - #210
Merged
skerbis merged 1 commit intoSep 17, 2026
Merged
Conversation
Browsers don't submit a multi-select field at all when every option is deselected, so the previously saved value for quick_navigation_favs<id> and quick_navigation_addon_favs<id> was never overwritten with an empty selection — the old favorites kept reappearing after save. Normalize both to an empty array when missing from the POST payload, matching the existing handling for quick_navigation_disabled_buttons<id>. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
skerbis
added a commit
to skerbis/quick_navigation
that referenced
this pull request
Sep 17, 2026
Resolves conflicts in package.yml/CHANGELOG.md from FriendsOfREDAXO#209/FriendsOfREDAXO#210/FriendsOfREDAXO#212 having merged first: bumps the version to 9.2.1 (patch on top of the now-released 9.2.0) and keeps both changelog entries. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<select multiple>isn't submitted at all by browsers, soquick_navigation_favs<id>/quick_navigation_addon_favs<id>were simply absent from the POST payload, and$package->setConfig($config)never touched (let alone cleared) those keys.quick_navigation_disabled_buttons<id>: default both to an empty array when missing from the submitted config before saving.Test plan
🤖 Generated with Claude Code