Skip to content

Fix: restore deprecated API class aliases removed in cleanup (#208) - #211

Merged
skerbis merged 2 commits into
FriendsOfREDAXO:mainfrom
skerbis:fix/restore-legacy-api-class-aliases
Sep 17, 2026
Merged

skerbis merged 2 commits into
FriendsOfREDAXO:mainfrom
skerbis:fix/restore-legacy-api-class-aliases

Conversation

@skerbis

@skerbis skerbis commented Sep 17, 2026

Copy link
Copy Markdown
Member

Summary

Fixes #208 ("Class "rex_api_quicknavigation_render" not found" after updating the addon).

This is a regression: rex_api_quicknavigation_render and rex_api_quicknavigation_media_search were added as @deprecated global-namespace alias classes to fix the exact same error previously reported in #165. They were removed again in a later CS-Fixer/cleanup pass (833f2a0, "deprecated methoden und classes entfernt"), without the underlying cause being addressed — reintroducing the bug for anyone hitting the same stale-cache window.

Root cause: REDAXO keeps a global autoload classmap cache (cache/core/autoload.cache). On some addon updates — especially on older core versions, per the reporter's 5.15.1 — this cache isn't reliably rebuilt for every affected class right after the package update finishes, so a stale reference to the old class name can survive until a full cache rebuild happens (a Safe Mode toggle forces exactly that, which is why it "fixes" the problem for affected users).

Fix: restore both deprecated alias classes so installations that hit this stale-cache window keep working without needing a manual Safe Mode toggle, exactly as intended when #165 was originally fixed.

Version bumped to 9.1.1, CHANGELOG updated.

Test plan

  • Confirmed both restored files are plain global-namespace class aliases extending the current namespaced classes (FriendsOfRedaxo\QuickNavigation\ApiFunction\MenuRender / MediaSearch), matching their state right before removal
  • php -l clean on both files
  • Can't reproduce the actual stale-cache condition locally (it depends on REDAXO core's update-time cache rebuild timing on specific older core versions) — restoring the exact previously-working fix for the identical previously-reported issue (Während des Updates: Class "rex_api_quicknavigation_render" not found #165) is the safest available remediation

🤖 Generated with Claude Code

skerbis and others added 2 commits September 17, 2026 19:58
…OfREDAXO#208)

rex_api_quicknavigation_render and rex_api_quicknavigation_media_search
were removed in a CS-Fixer/cleanup pass, but they were originally added
as a fix for FriendsOfREDAXO#165: REDAXO's global autoload classmap cache isn't always
rebuilt for every affected class right after an addon update (observed
on older core versions), so a stale cache can still reference the old
class name until a full cache rebuild happens (e.g. via a Safe Mode
toggle). Restoring both deprecated aliases makes upgrades resilient to
that stale-cache window again, same as before FriendsOfREDAXO#165 was fixed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Resolves conflicts in package.yml/CHANGELOG.md from FriendsOfREDAXO#209/FriendsOfREDAXO#210/FriendsOfREDAXO#212
having merged first: bumps the version to 9.2.1 (patch on top of
the now-released 9.2.0) and keeps both changelog entries.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@skerbis
skerbis merged commit 7aaa53c into FriendsOfREDAXO:main Sep 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nach Update auf neueste Version kommt diese Fehlermeldung

1 participant