Repository navigation
Fix: restore deprecated API class aliases removed in cleanup (#208) - #211
Merged
skerbis merged 2 commits intoSep 17, 2026
Merged
Conversation
…OfREDAXO#208) rex_api_quicknavigation_render and rex_api_quicknavigation_media_search were removed in a CS-Fixer/cleanup pass, but they were originally added as a fix for FriendsOfREDAXO#165: REDAXO's global autoload classmap cache isn't always rebuilt for every affected class right after an addon update (observed on older core versions), so a stale cache can still reference the old class name until a full cache rebuild happens (e.g. via a Safe Mode toggle). Restoring both deprecated aliases makes upgrades resilient to that stale-cache window again, same as before FriendsOfREDAXO#165 was fixed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Resolves conflicts in package.yml/CHANGELOG.md from FriendsOfREDAXO#209/FriendsOfREDAXO#210/FriendsOfREDAXO#212 having merged first: bumps the version to 9.2.1 (patch on top of the now-released 9.2.0) and keeps both changelog entries. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #208 ("Class "rex_api_quicknavigation_render" not found" after updating the addon).
This is a regression:
rex_api_quicknavigation_renderandrex_api_quicknavigation_media_searchwere added as@deprecatedglobal-namespace alias classes to fix the exact same error previously reported in #165. They were removed again in a later CS-Fixer/cleanup pass (833f2a0, "deprecated methoden und classes entfernt"), without the underlying cause being addressed — reintroducing the bug for anyone hitting the same stale-cache window.Root cause: REDAXO keeps a global autoload classmap cache (
cache/core/autoload.cache). On some addon updates — especially on older core versions, per the reporter's5.15.1— this cache isn't reliably rebuilt for every affected class right after the package update finishes, so a stale reference to the old class name can survive until a full cache rebuild happens (a Safe Mode toggle forces exactly that, which is why it "fixes" the problem for affected users).Fix: restore both deprecated alias classes so installations that hit this stale-cache window keep working without needing a manual Safe Mode toggle, exactly as intended when #165 was originally fixed.
Version bumped to 9.1.1, CHANGELOG updated.
Test plan
FriendsOfRedaxo\QuickNavigation\ApiFunction\MenuRender/MediaSearch), matching their state right before removalphp -lclean on both files🤖 Generated with Claude Code