Repository navigation
Fix #214: Medien-Live-Suche ohne error_log(), Ausgabe maskiert (9.3.1) - #216
Merged
Merged
Conversation
…on 9.3.1 - error_log()-Debugaufrufe entfernt (Abbruch, wenn error_log per disable_functions gesperrt ist) - Trefferliste: Titel, Dateinamen, Meldungen maskiert; Übernehmen über data-Attribute statt onclick - SVG-Vorschau als <img> statt Inline-Markup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #214
Ursache
MediaSearch::execute()rief bei jeder Sucheerror_log()auf (Debug-Reste). Ist die Funktion beim Hoster perdisable_functionsgesperrt, sucht PHP sie im NamespaceFriendsOfRedaxo\QuickNavigation\ApiFunctionund bricht mit Call to undefined function ab. Die Aufrufe schrieben außerdem Suchbegriffe und SQL ins Server-Log.Änderungen
error_log()-Aufrufe entferntdata-Attribute und einen delegierten Handler statt überonclick-Strings (Titel mit'oder<brachen die Liste bzw. wurden als HTML ausgeführt)<img>(rex_url::media()) statt Inline-Markup mit Regex-Bereinigungempty(), unbenutzte Variable)Geprüft
MediaSearch.php,node --checkfür das JS