fix(ppt-live): inherit model and preserve PDF text - #2121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: N/A
Type and Areas
Type: bug fix, regression fix, UI/UX, test
Areas: PPT Live built-in MiniApp, web UI chat model selection, desktop/Tauri export host
Motivation / Impact
PPT Live now has one model-selection surface: the shared floating chat input used to submit generation requests. Existing saved decks no longer restore a stale MiniApp-owned model preference, and the hidden agent session receives model and reasoning changes from that shared selector.
PDF export no longer relies on charset sniffing for sanitized full-document slide HTML, preventing Chinese and other non-ASCII text from becoming mojibake.
Verification
pnpm run test:ppt-live— 194 passedpnpm --dir src/web-ui run test:run src/flow_chat/components/ModelSelectorExternal.test.tsx— 7 passedpnpm run type-check:web— passedpnpm --dir src/web-ui exec eslint src/flow_chat/components/ModelSelector.tsx src/flow_chat/utils/modelSelectionTarget.ts— passedpnpm run check:repo-hygiene— passedcargo test -p bitfun-product-domains --features miniapp ppt_live_bundle_uses_bitfun_host_capabilities— passedcargo check -p bitfun-desktop— passedcargo test -p bitfun-desktop— 281 passed, 2 ignoredcafécorrectly; Poppler text extraction and page rendering both confirmed the output.Reviewer Notes
Checklist