fix(acp-agents): allow deleting remote server entries - #2122
Open
xielixing wants to merge 1 commit into
Open
Conversation
… page Add a Delete button to each remote server row in the ACP Agents config page. The handler calls sshApi.deleteConnection() to remove the saved SSH connection, cleans up probe state, and shows success/error notifications. A confirmation dialog prevents accidental deletion. Fixes GCWing#2035
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2035
Adds the ability to delete remote server entries from the ACP Agents configuration page. Previously, when a remote SSH server was used, an ACP Agent entry was auto-created but could not be removed. If the server was no longer in use, the entry cluttered the UI indefinitely.
Changes
deleteRemoteConnectionhandler that callssshApi.deleteConnection(), removes the connection fromsavedConnectionsstate, cleans up probe data, and shows success/error notifications. Added a Delete button (red/danger variant) next to the existing Refresh button for each remote server row.en-US,zh-CN,zh-TW): Addedremote.deleteConnection,remote.deleteConfirm,notifications.deleteConnectionSuccess, andnotifications.deleteConnectionFailedkeys.Behavior
sshApi.deleteConnection(connectionId)is calledValidation
tsc --noEmitpasses (no errors in modified files)AcpAgentsConfig.test.tsxtests passpnpm run i18n:auditpasses with 0 warnings