fix(review): allow ReviewFixer as builtin session primary agent - #2126
Open
xielixing wants to merge 1 commit into
Open
fix(review): allow ReviewFixer as builtin session primary agent#2126xielixing wants to merge 1 commit into
xielixing wants to merge 1 commit into
Conversation
PR GCWing#2106 (commit 97a4afa) added CodeReview and DeepReview to the is_builtin_session_primary_agent whitelist but missed ReviewFixer. This caused the review fix phase to fail with: 'Failed to start dialog turn: Unknown session mode: ReviewFixer' Add REVIEW_FIXER_AGENT_TYPE to the whitelist so ReviewFixer child sessions resolve through the primary-agent path for create, turn, restore, and compaction — matching CodeReview and DeepReview. Closes GCWing#2124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The review fix phase fails with:
Root Cause
PR #2106 (commit
97a4afaa5) addedCodeReviewandDeepReviewto theis_builtin_session_primary_agentwhitelist but missedReviewFixer. The fix phase creates child sessions withagentType=ReviewFixer, which then fails to resolve through the primary-agent path because it's not in the whitelist.Fix
Add
REVIEW_FIXER_AGENT_TYPEto theis_builtin_session_primary_agentwhitelist inexternal.rs, soReviewFixerchild sessions resolve through the primary-agent path for create, turn, restore, and compaction — matchingCodeReviewandDeepReview.Changes
external.rs: ImportREVIEW_FIXER_AGENT_TYPEand add it to theis_builtin_session_primary_agentmatches!arm. Updated doc comments to mentionReviewFixer.tests.rs: AddedReviewFixertobuiltin_review_agents_resolve_as_local_session_primariesandlocal_route_resolves_review_agents_as_session_primariestest arrays.coordinator.rs: AddedReviewFixerto thereview_agent_child_sessions_create_successfullytest array.Validation
cargo check -p bitfun-core— passedcargo test -p bitfun-core— all 4 targeted tests pass:builtin_review_agents_resolve_as_local_session_primaries✅non_session_primary_subagents_and_unknown_ids_do_not_resolve✅ (ReviewWorker still restricted)local_route_resolves_review_agents_as_session_primaries✅review_agent_child_sessions_create_successfully✅Closes #2124