feat(skin-market): show submitter GitHub account in review - #2148
Merged
Conversation
The admin review page had no way to tell which GitHub account sent a submission. Expose the submission owner on the admin detail response and render it as a linked avatar in the review facts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The skin market admin review page (
/skin/admin) shows package metadata and hashes but never says which GitHub account submitted the package, so reviewers can't tell who sent it.Change
AppearanceAdminSubmissionDetailgains an optionalsubmitter(AppearanceMarketUserSummary); the field is#[serde(default)]so older clients/servers stay compatible.admin_submission_detailleft-joinsusersonsubmissions.owner_user_idto fill it.@loginlinking to the GitHub profile (falls back to "Unknown account"). EN/ZH strings added.Verification
cargo test -p bitfun-skin-market-service(10 passed) — the bearer review flow test now assertssubmitter.login/submitter.githubId.npx tsc --noEmit,npm test(24 passed),npm run buildinsrc/skin-market-web.