feat: Change molarity concentration to molality concentration - #3996
Open
frankfeifan wants to merge 8 commits into
Open
feat: Change molarity concentration to molality concentration#3996frankfeifan wants to merge 8 commits into
frankfeifan wants to merge 8 commits into
Conversation
frankfeifan
added
the
ci: run integrated tests
frankfeifan
requested review from
MelReyCG,
corbett5 and
wrtobin
as code owners
March 16, 2026 20:16
frankfeifan
added
the
flag: requires rebaseline
dkachuma
approved these changes
Apr 6, 2026
…lityConcentration
…lityConcentration
…lityConcentration
frankfeifan
requested review from
jafranc,
jhuang2601 and
joshua-white
as code owners
September 1, 2026 16:43
frankfeifan
added
ci: run device builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes convention of the concentration fed into
HPCReactfrom molarity [mol/m3] or [mol/L] to molality [mol/kg], as a preparatory step for introducing the activity model.Specific changes include:
Switched the concentration passed to HPCReact from molarity to molality, converting back with the system's solvent density at every caller: accumulation, advective and diffusive flux, Dirichlet and source terms, and their thermal counterparts.
Sourced the solvent density from the solver's single reactive fluid model rather than a per-subregion scan, and turned the previously silent single-fluid-model assumption into an explicit input error, ensuring a single fluid model defined across all regions for a uniform dof layout.
Restored the finite-difference Jacobian test to
dt = 1.0, since the reduction to 0.01 was a workaround for the inflated reaction term.Rebaseline
Depends on GEOS-DEV/HPCReact#21