fix: raise errors for invalid shears and PixelScale WCS inits#242
fix: raise errors for invalid shears and PixelScale WCS inits#242beckermr wants to merge 6 commits into
Conversation
Merging this PR will improve performance by 33.46%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | test_benchmarks_lanczos_interp[xval-no_conserve_dc-run] |
1,105.5 µs | 828.3 µs | +33.46% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing equinox-errs (85569db) with main (d69a8ba)
|
OK @ismael-mendoza! This is the first PR in a series that adds runtime init checks to the various classes. I don't think I'll request review for all of them, but I wanted to get eyes on the first one so we all understand the syntax and implications. Please take a look! |
|
closing in favor of #243 |
This PR adds runtime init error checking to the Shear class. It uses the
equinox.error_iffunction. The net result is that the code now raises for invalid shears. Unfortunately there is no way to raise exceptions besides theequinox.EquinoxRuntimeErrorand according to the equinox issue tracker, enabling custom exceptions is not a feature they plan to support. We can't use subclassing IIUIC because the inheritance goes the wrong way.xref: #237