Enable CET Compatibility for Release Builds - #692
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The linker option is correctly scoped to Release builds and reaches all native executable and shared-library targets.
Review effort: Balanced
Findings: None
What changed in this PR
Enables CET shadow-stack compatibility for Release binaries through the shared linker policy.
Changes:
- Adds
/CETCOMPATto Release linker options.
| File | Description |
|---|---|
cmake/PresentMonCompiler.cmake |
Enables CET compatibility for Release executable and DLL links. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
planetchili
approved these changes
Oct 5, 2026
planetchili
left a comment
planetchili
left a comment
Collaborator
There was a problem hiding this comment.
Smart addition, not problems here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
/CETCOMPATto Release builds to enable CET shadow stack compatibility and improve exploit protection for shipped binaries.