Repository navigation
Treat an incomplete first slave search as incomplete - #281
Merged
Merged
Conversation
RBS ignored the result of the slave configuration for the first search and treated that search as complete. When a restricted first slave found no solution, RBS reported that as a proof that no solution exists. FlatZinc posts the values of its on_restart predicates already in the first slave, and returns false. With a random value from gecode_on_restart_uniform_int that admits no solution, a satisfiable model was reported as unsatisfiable. A failed root used to make RBS restart instead, which hid this for root failures until failed roots were counted as exhausted searches. Use the result of the slave configuration for the first search as for the searches after later restarts.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 6.6.0 release preparation failed
check-standard:FlatZinc::on_restart::uniform_int_upper_boundreports a satisfiable model as unsatisfiable for some seeds. Gecode 6.5.0 solves it for all of them.RBS ignored the result of the slave configuration for the first search and treated that search as complete. FlatZinc posts the values of its on_restart predicates already in the first slave and returns false. When the random value from
gecode_on_restart_uniform_intadmits no solution, RBS took the exhausted first search as a proof. A failed root used to make RBS restart instead, which hid this for root failures until #280 counted failed roots as exhausted searches. A restricted first search that failed deeper in the tree was affected before as well.RBS now uses the result of the slave configuration for the first search, as for the searches after later restarts. The
slave()and RBS constructor documentation is updated, and there is a changelog entry in the 6.6.0 section.The new test
Search::RBS::FailedFirstSlavefails without the fix. With it,checkpasses 539/539 andcheck-standard6750/6750 locally; Gecode CI does not run the FlatZinc tests.