Skip to content

Treat an incomplete first slave search as incomplete - #281

Merged
zayenz merged 1 commit into
mainfrom
fix/rbs-first-slave-complete
Nov 16, 2026
Merged

zayenz merged 1 commit into
mainfrom
fix/rbs-first-slave-complete

Conversation

@zayenz

@zayenz zayenz commented Nov 16, 2026

Copy link
Copy Markdown
Member

The 6.6.0 release preparation failed check-standard: FlatZinc::on_restart::uniform_int_upper_bound reports a satisfiable model as unsatisfiable for some seeds. Gecode 6.5.0 solves it for all of them.

RBS ignored the result of the slave configuration for the first search and treated that search as complete. FlatZinc posts the values of its on_restart predicates already in the first slave and returns false. When the random value from gecode_on_restart_uniform_int admits no solution, RBS took the exhausted first search as a proof. A failed root used to make RBS restart instead, which hid this for root failures until #280 counted failed roots as exhausted searches. A restricted first search that failed deeper in the tree was affected before as well.

RBS now uses the result of the slave configuration for the first search, as for the searches after later restarts. The slave() and RBS constructor documentation is updated, and there is a changelog entry in the 6.6.0 section.

The new test Search::RBS::FailedFirstSlave fails without the fix. With it, check passes 539/539 and check-standard 6750/6750 locally; Gecode CI does not run the FlatZinc tests.

RBS ignored the result of the slave configuration for the first search
and treated that search as complete. When a restricted first slave found
no solution, RBS reported that as a proof that no solution exists.
FlatZinc posts the values of its on_restart predicates already in the
first slave, and returns false. With a random value from
gecode_on_restart_uniform_int that admits no solution, a satisfiable
model was reported as unsatisfiable. A failed root used to make RBS
restart instead, which hid this for root failures until failed roots
were counted as exhausted searches.

Use the result of the slave configuration for the first search as for
the searches after later restarts.
@zayenz
zayenz merged commit 5bb63ff into main Nov 16, 2026
16 checks passed

This branch was successfully deployed

1 active deployment
github-pages — 5bb63ffa Deployed Nov 16, 2026 by zayenz via deploy #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant