Release 0.5.15: honor --no-slim on Android, Apple-strip lib execs, gate plugin flags#15
Merged
Merged
Conversation
…te plugin flags Three fixes surfaced shipping a full-OTP Livebook-host app: - Android --no-slim was ignored (OtpAssetBundle stripped unconditionally). Thread slim through build_aab → OtpAssetBundle.build(slim:); slim:false ships the full OTP tree (needed for runtime Mix.install). Default unchanged. - iOS --no-slim bundle failed App Store validation on standalone execs inside OTP libs (erl_interface/bin/erl_call, 90171). Always-on Apple strip now also removes lib/*/bin/* executables, keeping each lib's .beam/.app. - native_build emitted -Dplugin_* flags unconditionally; apps scaffolded before the plugin system have no such build.zig options and Zig rejects them. Emit the plugin flags (and the iOS bootstrap) only when plugins are activated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes found shipping a full-OTP, no-slim Livebook-host app (Io) to both stores.
1.
--no-slimignored on AndroidMobDev.ReleaseAndroid.build_aab/0calledOtpAssetBundle.build/2with no opts, so the OTP-lib strip ran unconditionally andmix mob.release --android --no-slimstill shipped a stripped runtime. An app that lostruntime_tools(in itsextra_applications) crashed on boot;inetsloss brokeMix.install/Hex. Nowslimthreadsbuild_aab → OtpAssetBundle.build(slim:), andslim: falseships the OTP tree untouched. Default staysslim: true. Regression test added.2. iOS
--no-slimbundle rejected by App Store validationThe always-on Apple-policy strip removed
erts-*/binandpriv/binbut missed standalone executables inside OTP libs (e.g.erl_interface/bin/erl_call) →altool90171 "Invalid bundle structure". Nowlib/*/bin/*executables are stripped too (always on, not gated on slim), keeping each lib's.beam/.app, so a full-OTP bundle is Apple-compliant.3. Native builds break on pre-plugin app scaffolding
native_build.exemitted-Dplugin_c_nifs/-Dplugin_zig_nifs/-Dplugin_jni_sources(Android) and-Dplugin_swift_files/-Dplugin_frameworks(iOS) unconditionally. An app scaffolded before the plugin system has no such options in itsbuild.zig, and Zig aborts withinvalid option: -Dplugin_*. These flags (and the iOS plugin bootstrap, which otherwise madeplugin_swift_filesalways non-empty) are now emitted only when plugins are activated; a plugin-awarebuild.zigdefaults them to"", so behaviour there is unchanged.Verification
slim: falsetest).--no-slimAAB built + booted on a Pixel 8 emulator (full OTP).--no-slimIPA built + accepted by App Store Connect.🤖 Generated with Claude Code