Release 0.5.16: gate plugin flags on the iOS device build path too#16
Merged
Conversation
0.5.15 gated Android + iOS-sim but missed zig_build_binary_ios_device, which still emitted -Dplugin_swift_files/-Dplugin_frameworks (+ generated the bootstrap) unconditionally — so `mix mob.deploy --native` to a physical iPhone broke on pre-plugin app scaffolding. The device path now mirrors the sim path. Verified: mob.deploy --native to a physical iPhone → full OTP, Phoenix up, LiveView connected, embedded Livebook home rendered. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.5.15 gated Android + iOS-sim plugin flags but missed
zig_build_binary_ios_device, which still emitted-Dplugin_swift_files/-Dplugin_frameworks(and generated the bootstrap, makingplugin_swift_filesalways non-empty) unconditionally. Somix mob.deploy --nativeto a physical iPhone broke on an app scaffolded before the plugin system (invalid option: -Dplugin_swift_files). The device path now mirrors the sim path — bootstrap + flags only when plugins are activated.Verified:
mix mob.deploy --nativeto a physical iPhone (iPhone SE 3rd gen) → full OTP, Phoenix endpoint up, LiveView socket connected, embedded Livebook home mounted. 105 native_build tests pass.🤖 Generated with Claude Code