Skip to content

fix(profiles): tidy review nits from #1992 re-review - #2640

Merged
barbatdev merged 1 commit into
mainfrom
fix/1992-review-nits
Oct 29, 2026
Merged

barbatdev merged 1 commit into
mainfrom
fix/1992-review-nits

Conversation

@barbatdev

Copy link
Copy Markdown
Contributor

Summary

Applies the two non-blocking nits from decode2's independent re-review of #1992:

  1. lib/session-profile-integration.ts — move the stranded /** Await before fork-copy/tree movement and before detach/invalidation. */ doc comment back above waitCurrentSessionProfileSelection (it was left sitting above hasPendingSessionProfileSelection when that helper was inserted between them).
  2. extensions/gentle-ai.ts — compare the current() session snapshot in the use-session case with isDeepStrictEqual (the repo's established node:util pattern) instead of JSON.stringify on both sides.

Behavior

None observable: the first change is a doc comment, the second is a semantically equivalent comparison over serializable data. No new tests; the existing session-profile-integration, session-profile-binding and session-profile-extension suites cover both spots and pass.

Verification

  • node --experimental-strip-types --test tests/session-profile-integration.test.ts tests/session-profile-binding.test.ts — 44 pass, 0 fail
  • node --experimental-strip-types --test tests/session-profile-extension.test.ts — 23 pass, 0 fail

Risk: none

Move the stranded fork-copy await doc comment back above
waitCurrentSessionProfileSelection, and compare the current()
session snapshot with isDeepStrictEqual instead of JSON.stringify.
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@barbatdev
barbatdev merged commit 4176a2c into main Oct 29, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant