Repository navigation
fix(profiles): tidy review nits from #1992 re-review - #2640
Merged
Merged
Conversation
Move the stranded fork-copy await doc comment back above waitCurrentSessionProfileSelection, and compare the current() session snapshot with isDeepStrictEqual instead of JSON.stringify.
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the two non-blocking nits from decode2's independent re-review of #1992:
/** Await before fork-copy/tree movement and before detach/invalidation. */doc comment back abovewaitCurrentSessionProfileSelection(it was left sitting abovehasPendingSessionProfileSelectionwhen that helper was inserted between them).current()session snapshot in theuse-sessioncase withisDeepStrictEqual(the repo's establishednode:utilpattern) instead ofJSON.stringifyon both sides.Behavior
None observable: the first change is a doc comment, the second is a semantically equivalent comparison over serializable data. No new tests; the existing
session-profile-integration,session-profile-bindingandsession-profile-extensionsuites cover both spots and pass.Verification
node --experimental-strip-types --test tests/session-profile-integration.test.ts tests/session-profile-binding.test.ts— 44 pass, 0 failnode --experimental-strip-types --test tests/session-profile-extension.test.ts— 23 pass, 0 failRisk: none