Add exact chart deep links - #105
Open
Jamesllllllllll wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bridge://linksbridge://chart/{md5}Why I am proposing this
I am adding optional Clone Hero and YARG library support to RockList (a Twitch, Kick, YouTube and TikTok request bot for music streamers). When a requested song is not in a streamer’s uploaded library, RockList can find a matching chart through Enchor. An exact deep link lets RockList hand that chart to Bridge, where the streamer can review and download it using their existing settings, without RockList downloading or managing chart files itself.
I am offering this because the same small integration point can be useful to other tools that already know a chart’s MD5.
Validation
npx tsc -p src-electron/tsconfig.electron.jsonnpx ng build -c productionRelated issue
Related to #97. This PR intentionally starts with exact chart links using an MD5 hash. It does not implement the proposed metadata search format, such as
bridge://search?title=...&artist=...; that could be added as a compatible extension later.