Skip to content

test(e2e): run the giphy tests on Android again - #3977

Draft
testableapple wants to merge 4 commits into
developfrom
ci/rn-513-android-giphy
Draft

testableapple wants to merge 4 commits into
developfrom
ci/rn-513-android-giphy

Conversation

@testableapple

@testableapple testableapple commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Ticket: https://linear.app/stream/issue/RN-513

🎯 Goal

Run the 9 GiphyTests cases on Android again. They became iOS-only (itOnIOS) because loading giphy media sometimes took the whole Android CI emulator down.

πŸ›  Implementation details

  • RN-513 was recorded with -gpu swiftshader_indirect. CI has used -gpu swangle_indirect since ci(e2e): fix nightly reporting and stabilize the iOS suiteΒ #3965, and the giphy tests no longer take the emulator down with it (see Testing).
  • GiphyTests: itOnIOS β†’ it. This removes itOnIOS, which only these tests used, and its mentions in the e2e README and the Fastfile's test-id regex.
  • assertMessageDeliveryStatus(NIL) now looks only inside the list's message cells. Since RN-493, a thread shows its parent message's delivery status, and the parent renders outside any cell (ThreadFooterComponent). The old whole-list check failed test_deliveryStatusHidden_whenEphemeralMessageShownInThread on Android every time, on the parent's βœ“, not the giphy's. The same cause likely explains its occasional iOS failures (nightly 42943115860). Checks that expect a status still see the parent.

πŸ§ͺ Testing

  • Stress runs (Android, GiphyTests only, 8 batches each, so every batch starts with a giphy test): 6 runs, 48 batches, 0 emulator losses. With SwiftShader, 1–2 of 8 batches per run lost the emulator.
  • Full suite on this PR: 43086744717, all 8 Android batches green.
  • The stress selection was a temporary commit, reverted in the last commit, so the net diff doesn't touch it.
  • yarn typecheck (E2ETestApp), eslint and prettier pass on the changed files.

β˜‘οΈ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

The emulator deaths in RN-513 came with -gpu swiftshader_indirect. CI has
used swangle_indirect since #3965, so the giphy tests no longer need to be
iOS-only. This also removes the itOnIOS helper, which only they used.
Since RN-493 a thread shows its parent message's delivery status. The
parent sits outside the list's message cells, so the NIL check now looks
only inside them. This fixes the in-thread ephemeral giphy test.
Reverts the temporary GiphyTests-only stress selection.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant