webrtc: Expose CaptureCompressionGain and GainController1 config for Java - #111
XiaWuSharve wants to merge 4 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| return; | ||
| } | ||
| webrtc::AudioProcessing::Config config = default_processor->apm()->GetConfig(); | ||
| config.gain_controller1.enabled = true; |
There was a problem hiding this comment.
Should this also clear analog_gain_controller.enabled for the two digital modes? It defaults to true, and InitializeGainController1 only applies mode/target_level_dbfs/compression_gain_db/enable_limiter when it is false — otherwise SetupDigitalGainControl overwrites all four.
Same flag keeps agc_manager alive, which is the branch that skips kCaptureCompressionGain — does setCaptureCompressionGain actually land for you?
2 participants
This CL exposes the capture compression gain and GainController1
configuration APIs to the Java layer via ExternalAudioProcessingFactory.
Previously, these AGC parameters were not configurable from Java,
making it difficult to tune audio processing for specific communication
scenarios.
Changes:
target level, compression gain, and limiter.
Bug: None
Test: Manually tested with GetStream's WebRTC build