Repository navigation
Conversation
Signed-off-by: liyuan <yuali@nvidia.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a workaround for Debian 12 security kernels by overriding the NVIDIA driver version to 580.95.05 and implementing a repository-based installation path when USE_REPO_INSTALL is enabled. The feedback identifies a missing call to enable the contrib repository component in the new installation path, a redundant apt-get update execution, and an existing redirection bug in the clear_dkms_key function that creates an unwanted file named '2'.
nvliyuan
marked this pull request as ready for review
October 27, 2026 07:26
Contributor
Author
|
verified in local |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: liyuan <yuali@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spark-rapids/mig.shfrom the CUDA 12.4 local repository's NVIDIA 550 driver to the NVIDIA online repository's pinned 580 driver branch.nvidia-kernel-open-dkmsandnvidia-driver-cudapackages while keeping the CUDA toolkit at 12.4.Root cause
mig-on-dataproc-2.3-debian12build #13 failed during node initialization. The retainedmake.logfrom the reproduction shows NVIDIA driver550.54.15calling the three-argumentpci_resize_resource()API, while Debian 12 kernel headers6.1.0-53require four arguments. As a result, the NVIDIA DKMS module does not compile.The regular Spark RAPIDS init action already avoids this incompatibility after #1400, but the copied driver installation logic in
spark-rapids/mig.shstill used the old local installer.Validation
bash -n spark-rapids/mig.shgit diff --checknvidia-driver-pinning-580,nvidia-kernel-open-dkms,nvidia-driver-cuda, andcuda-toolkit-12-4.2.3-debian12A100 cluster withspark-rapids/mig.shand verify MIG configuration,nvidia-smi, and CUDA 12.4.