Repository navigation
fix: keep structured logs when --quiet is set - #2694
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
/gcbrun |
|
Thanks @Firehed for tracking this regression back to #2106 and adding a test to guard it, LGTM. One blocker: the CLA check is failing on the Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com trailer (your own CLA is fine). Could you drop that trailer from both commits and force-push? The check should go green after that. |
38cf3bc to
663f3eb
Compare
|
@kgala2 force push is done and I now see the CLA check passing. Let me know if you need anything else! |
|
/gcbrun |
d4a9471 to
ce69429
Compare
Fixes #2693.
With
--structured-logsand--quietboth set, the structured logger was created and then replaced by the plain-text quiet logger, so errors were written as plain text instead of JSON.NewStructuredLoggeralready takesquietand drops info-level output itself, so the plain-text quiet logger is now only used when structured logs are off.This restores the behavior from #1750 (the fix for #1738), which was lost when the logger setup moved in #2106. The new test covers the combined flags so this doesn't regress again.
🤖 Generated with Claude Code