feat(genai): add ToolFunctionCallingConfigWithText sample and standarize ToolFunctionDescriptionWithText sample#10314
Draft
Kef131 wants to merge 2 commits into
Draft
Conversation
…ctionDescriptionWithText test case
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new code sample, ToolFunctionCallingConfigWithText.java, to demonstrate forcing a specific function call using ToolConfig. It also updates ToolFunctionDescriptionWithText.java to use a simpler weather-based function calling example instead of the album sales example, and updates the integration tests accordingly. The feedback suggests improving the schema definition in the new sample by explicitly marking fields as required to ensure consistent structured output from the model.
ToolFunctionCallingConfigWithText sample and standarize ToolFunctionDescriptionWithText sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
b/530303154
ToolFunctionDescriptionWithText.javato use theget_current_weatherfunction declaration for consistency across SDK samples.ToolFunctionCallingConfigWithText.javato demonstrate usingFunctionCallingConfig(modeANYwithallowedFunctionNames) for forced function calling with the Google Gen AI SDK (google-genai).ToolsIT.javato include unit test coverage for the new and updated samples.Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only