Skip to content

chore(texttospeech): remove beta and duplicate list voices samples - #10381

Merged
amcolin merged 1 commit into
GoogleCloudPlatform:mainfrom
amcolin:remove-tts-list-voices-beta
Nov 11, 2026
Merged

amcolin merged 1 commit into
GoogleCloudPlatform:mainfrom
amcolin:remove-tts-list-voices-beta

Conversation

@amcolin

@amcolin amcolin commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Description

Remove beta and duplicate Text-to-Speech list voices samples

Fixes Internal b/584767600

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only

Compliance & Style

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample

Post-Approval Actions

  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added api: texttospeech Issues related to the Text-to-Speech API. samples Issues that are directly related to samples. labels Nov 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deletes several Google Cloud Text-to-Speech API sample files and their integration tests, including ListAllSupportedVoices, ListAllSupportedVoicesBeta, and their respective integration test files for both v1 and v1beta1 versions. I have no feedback to provide as there are no review comments.

@amcolin
amcolin marked this pull request as ready for review November 11, 2026 19:57
@amcolin
amcolin requested review from a team and yoshi-approver as code owners November 11, 2026 19:57
@snippet-bot

snippet-bot Bot commented Nov 11, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the samples are not in use, LGTM!

@amcolin
amcolin merged commit a8a4e10 into GoogleCloudPlatform:main Nov 11, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: texttospeech Issues related to the Text-to-Speech API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants