Fixed cloudbilling tests#17481
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a69faa5: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the build log @melinath, @NickElliot VCR tests complete for a69faa5! |
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Manual non-replaying run just to be safe: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_CLOUDBILLING/662520 |
|
Those passed too 👍 |
8fa08dd
Fixed hashicorp/terraform-provider-google#27287. Fixed hashicorp/terraform-provider-google#27283.
The tests are working fine except for failing to find the cloudbilling product while checking if the resource was destroyed.
This failure is a little surprising to me, because the rest of the test works fine (which would only be possible if the registry were working as expected.) But in any case, we can change this custom_code template to reference the product directly (which is what the generated code would do, and which will avoid the registration question altogether).
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.