Skip to content

Fixed cloudbilling tests#17481

Merged
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:tpg-27287
May 11, 2026
Merged

Fixed cloudbilling tests#17481
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:tpg-27287

Conversation

@melinath
Copy link
Copy Markdown
Member

@melinath melinath commented May 8, 2026

Fixed hashicorp/terraform-provider-google#27287. Fixed hashicorp/terraform-provider-google#27283.

The tests are working fine except for failing to find the cloudbilling product while checking if the resource was destroyed.

This failure is a little surprising to me, because the rest of the test works fine (which would only be possible if the registry were working as expected.) But in any case, we can change this custom_code template to reference the product directly (which is what the generated code would do, and which will avoid the registration question altogether).

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 8, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a69faa5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 1 insertion(+), 1 deletion(-)
google-beta provider View Diff 1 file changed, 1 insertion(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
7 6 1 0
Affected Service Packages
  • cloudbilling

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@melinath, @NickElliot VCR tests complete for a69faa5!

@melinath
Copy link
Copy Markdown
Member Author

melinath commented May 8, 2026

@modular-magician reassign-reviewer

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from NickElliot May 8, 2026 16:37
@melinath
Copy link
Copy Markdown
Member Author

melinath commented May 8, 2026

@melinath
Copy link
Copy Markdown
Member Author

melinath commented May 8, 2026

Those passed too 👍

@melinath melinath added this pull request to the merge queue May 11, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 8fa08dd May 11, 2026
23 checks passed
@melinath melinath deleted the tpg-27287 branch May 11, 2026 21:25
pragya644 pushed a commit to pragya644/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccCloudBillingProjectInfo_billingProjectInfoBasicExample Failing test(s): TestAccBillingProjectInfo_update

3 participants