Skip to content

chore(ci): upgrade Node.js version from 16 to 20 in workflows - #4427

Merged
angelcaamal merged 6 commits into
mainfrom
chore/upgrade-node-workflows-to-20
Aug 28, 2026
Merged

angelcaamal merged 6 commits into
mainfrom
chore/upgrade-node-workflows-to-20

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • Upgrades Node.js runtime target from 16 to 20 in CI test workflow configurations (.github/workflows/test-sample.yml).
  • Fixes zizmor/template-injection security warnings by routing workflow inputs (name and path) through intermediate environment variables before executing shell commands.

Fixes Internal: b/553550396

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Aug 27, 2026

@Kef131 Kef131 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the description, the CI is throwing errors until Node20 is merged on this PR

@amcolin
amcolin marked this pull request as ready for review August 28, 2026 16:44
@amcolin
amcolin requested review from a team as code owners August 28, 2026 16:45
@angelcaamal
angelcaamal merged commit fa13f39 into main Aug 28, 2026
23 of 27 checks passed
@angelcaamal
angelcaamal deleted the chore/upgrade-node-workflows-to-20 branch August 28, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants