[reginaldalfret]

Description

Fixes #4174

This PR addresses two maintenance and correctness issues in test configuration and workflow scripts:

1. Update ESLint rules for eslint-plugin-n (eslintrc rules may be invalid #4174):

   • Root package.json installs eslint-plugin-n, but .eslintrc.json defined rules using the legacy node/* prefix (node/no-missing-import, etc.).
   • Added corresponding n/* rule definitions (n/no-missing-import, n/no-missing-require, n/no-unpublished-import, n/no-unpublished-require, n/no-unsupported-features/es-syntax) so ESLint correctly applies rule overrides when using eslint-plugin-n.

2. Handle non-string variables and guard ID token in .github/scripts/setup-vars.js:

   • substituteVars crashed with TypeError: value.replaceAll is not a function when environment variables were numbers or booleans (e.g. {PORT: 8080}). Added a type check to return non-string inputs safely, and ensured replacement values are converted to string.
   • Guarded idToken handling: only call core.exportVariable('ID_TOKEN', idToken) and core.setSecret(idToken) when idToken is provided, preventing uninitialized tokens from exporting "undefined" and masking it across GitHub Actions workflow logs.
   • Added unit tests in .github/scripts/setup-vars.test.js covering non-string environment variables and conditional idToken secret masking.

Checklist

• I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
• Tests pass: npm test in .github/scripts passes (21/21 passing)
• Lint pass: configuration verified with eslint --print-config
• Please merge this PR for me once it is approved

[gemini-code-assist]

Code Review

This pull request updates the ESLint configuration to include 'n/*' rules, conditionally exports and sets the 'ID_TOKEN' secret only when provided, and hardens the 'substituteVars' function to handle non-string inputs and variables safely. Additionally, comprehensive unit tests are added to cover these new behaviors. A review comment suggests improving 'substituteVars' by replacing 'null' or 'undefined' environment variables with an empty string instead of their literal string representations to avoid unexpected values.

[gemini-code-assist]

If an environment variable in env is undefined or null, calling String(env[key]) will substitute the literal string "undefined" or "null" into the value. This can lead to unexpected and hard-to-debug values (e.g., "http://localhost:undefined"). It is safer to substitute an empty string "" instead.

Suggested change

	value = value.replaceAll(re, String(env[key]));
	value = value.replaceAll(re, env[key] == null ? '' : String(env[key]));