Skip to content

feat(CI): Added check for manual tests checkbox#14263

Closed
XrossFox wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
XrossFox:pipeline-disable-and-conthribution-edit
Closed

feat(CI): Added check for manual tests checkbox#14263
XrossFox wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
XrossFox:pipeline-disable-and-conthribution-edit

Conversation

@XrossFox
Copy link
Copy Markdown
Contributor

@XrossFox XrossFox commented Jun 2, 2026

Description

  • Added GitHub Workflow that checks wether a user has performed a manual test.

Fixes b/519321791

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

- Added GitHub Workflow that checks wether a user has
performed a manual test.
@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Jun 2, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pull request template to recommend running local tests with Python 3.10 instead of Python 3.9. The reviewer recommends keeping the test command set to Python 3.9 to ensure compatibility with the minimum supported Python version and to prevent contributors from introducing incompatible Python 3.10+ features.

Comment thread .github/PULL_REQUEST_TEMPLATE.md
@XrossFox XrossFox force-pushed the pipeline-disable-and-conthribution-edit branch from dae7310 to c44f868 Compare June 2, 2026 23:17
@XrossFox XrossFox marked this pull request as ready for review June 3, 2026 18:12
@XrossFox XrossFox requested review from a team as code owners June 3, 2026 18:12
@XrossFox
Copy link
Copy Markdown
Contributor Author

XrossFox commented Jun 3, 2026

You can see, that unchecking the testing tickbox, causes a Fail, now.

image

@iennae
Copy link
Copy Markdown
Contributor

iennae commented Jun 3, 2026

Thanks for the contribution, we don't need the GitHub Action to check for the checklist. Linting now occurs. if someone doesn't actually include that they tested, when reviewing, ask them.

@iennae iennae closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants