Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #368.
I guard the Unicode-only comparison in
BoundFunctionWrappercall dispatch withPyUnicode_Check. Ordinary non-string values then use the existing fallback path, as they do in the pure Python implementation, while normal string bindings and disabled wrappers keep their current behavior.The regression tests cover free functions and bound class methods with ordinary non-string bindings, unknown string bindings, and disabled wrappers. The change note credits the original report.
Validation on macOS arm64:
okwith the original pure Python implementation.just testpasses all 24 matrix cells: Python 3.10–3.15, including 3.14t/3.15t, with pure Python, C enabled, and C disabled at runtime. The 3.15 interpreters tested were 3.15.0rc2.just test-mypypasses all six configured target versions with the pinned mypy 1.20.1.