Skip to content

New nodes: 'Voronoi Cells', 'Tesselate', and 'Relax Points'#4345

Open
Keavon wants to merge 1 commit into
masterfrom
voronoi
Open

New nodes: 'Voronoi Cells', 'Tesselate', and 'Relax Points'#4345
Keavon wants to merge 1 commit into
masterfrom
voronoi

Conversation

@Keavon

@Keavon Keavon commented Jul 16, 2026

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Delaunay triangulation, Voronoi diagram generation, and Lloyd's relaxation nodes to the vector library, leveraging the delaunator crate. It also updates path-closing logic to prevent duplicate closing anchors for near-coincident endpoints. The review feedback highlights critical issues to address: correcting the perpendicular vector calculation in voronoi.rs to ensure unbounded cells project outward, clamping the relaxation iterations to prevent hangs from infinite or extremely large values, and enforcing a minimum threshold on the mesh weld tolerance to avoid division-by-zero errors on extremely small bounds.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread node-graph/nodes/vector/src/voronoi.rs
Comment thread node-graph/nodes/vector/src/voronoi.rs
Comment thread node-graph/nodes/vector/src/vector_nodes.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant