Skip to content

New nodes: Sort, Filter, Reverse, Shift, Shuffle, Number Sequence, List Indices, List Slice, Read Number#4347

Merged
Keavon merged 1 commit into
masterfrom
common-list-nodes
Jul 17, 2026
Merged

New nodes: Sort, Filter, Reverse, Shift, Shuffle, Number Sequence, List Indices, List Slice, Read Number#4347
Keavon merged 1 commit into
masterfrom
common-list-nodes

Conversation

@Keavon

@Keavon Keavon commented Jul 16, 2026

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several list manipulation nodes, including filter, reverse, shift, shuffle, number sequence, sort, and sort_key, along with comprehensive unit tests. Feedback on these changes suggests using saturating_add in the shift node to prevent potential underflow when amount is extremely negative, and utilizing total_cmp instead of partial_cmp for floating-point comparisons in ElementOrder to ensure a strict total ordering and avoid transitivity violations with NaN values.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread node-graph/nodes/graphic/src/graphic.rs
Comment thread node-graph/nodes/graphic/src/graphic.rs

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Confidence score: 5/5

  • Safe to merge after the addressed issues were fixed.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread node-graph/nodes/graphic/src/graphic.rs Outdated
@Keavon
Keavon force-pushed the common-list-nodes branch from 2033978 to 66e7892 Compare July 16, 2026 22:12
@Keavon
Keavon force-pushed the common-list-nodes branch from 66e7892 to 64a5f30 Compare July 17, 2026 04:42
@Keavon
Keavon force-pushed the common-list-nodes branch from 64a5f30 to e417c84 Compare July 17, 2026 07:44
@Keavon Keavon changed the title New nodes: 'Sort', 'Sort Key', 'Filter', 'Reverse', 'Shift', 'Shuffle', and 'Number Sequence' New nodes: 'Sort', 'Filter', 'Reverse', 'Shift', 'Shuffle', 'Number Sequence', 'List Indices', and 'Read Number' Jul 17, 2026
@Keavon Keavon changed the title New nodes: 'Sort', 'Filter', 'Reverse', 'Shift', 'Shuffle', 'Number Sequence', 'List Indices', and 'Read Number' New nodes: Sort, Filter, Reverse, Shift, Shuffle, Number Sequence, List Indices, and Read Number Jul 17, 2026
@Keavon Keavon changed the title New nodes: Sort, Filter, Reverse, Shift, Shuffle, Number Sequence, List Indices, and Read Number New nodes: Sort, Filter, Reverse, Shift, Shuffle, Number Sequence, List Indices, Read Number Jul 17, 2026
@Keavon
Keavon force-pushed the common-list-nodes branch from e417c84 to 019f2c0 Compare July 17, 2026 08:03
@Keavon Keavon changed the title New nodes: Sort, Filter, Reverse, Shift, Shuffle, Number Sequence, List Indices, Read Number New nodes: Sort, Filter, Reverse, Shift, Shuffle, Number Sequence, List Indices, List Slice, Read Number Jul 17, 2026
@Keavon
Keavon merged commit 048c458 into master Jul 17, 2026
10 checks passed
@Keavon
Keavon deleted the common-list-nodes branch July 17, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant