Repository navigation
TP: home page navigation links ignore the /ThirdParty context path (404); dead energyos.github.io doc links #235
Description
Problem
The Third Party runs under the context path /ThirdParty, but its Thymeleaf templates use hard-coded root-relative links. Every internal navigation link on the home page returns 404.
Link on /ThirdParty/ and /ThirdParty/home |
Requested | Result | Correct path |
|---|---|---|---|
Brand and "Home" href="/" |
http://localhost:8082/ |
404 | /ThirdParty/ → 200 |
"About" href="/about" |
/about |
404 | /ThirdParty/about → 302 to login |
"Login" href="/login" |
/login |
404 | /ThirdParty/login → 200 |
The same href="/" pattern appears in error.html, login.html, TermsOfService.html and UsagePolicy.html.
Two external links in home.html (lines ~176 and ~195) are also dead:
http://energyos.github.io/OpenESPI-GreenButton-API-Documentation/→ 404http://energyos.github.io/OpenESPI-GreenButton-API-Documentation/API/→ 404
The Bootstrap CDN, greenbuttondata.org and GitHub links work.
Fix
- Use Thymeleaf context-relative URLs:
th:href="@{/}",th:href="@{/about}",th:href="@{/login}", and so on, in every template. - Replace or remove the two energyos.github.io links, for example pointing them at the current Green Button documentation.
- Optional: a MockMvc test that renders
homeand checks that every internalhrefstarts with the context path.
Found by checking the Third Party home page links with the local profile.
Activity
fix(GreenButtonAlliance#235): correct context-relative links in Thyme…
fix(thirdparty): point API documentation links at greenbuttonalliance…
dfcoffin commentedon Nov 14, 2026
Fixed on
mainby:energyos.github.iodocumentation links now point atgreenbuttonalliance.github.io/OpenESPI-GreenButton-API-Documentation/(both verified 200).templates/fragments/layout.html) whose internal links are all context-relative (th:href="@{...}"), so they resolve under/ThirdParty. The dead/aboutlink was removed at that point; feat: Third Party About page; About pages show product identity, not framework versions #248 adds a real About page.GbaLayoutPagesTestchecks the public pages. In feat: Third Party About page; About pages show product identity, not framework versions #248 it renders them under the real/ThirdPartycontext path and fails if any internalhref/srclacks it.mainhas no root-relative internal links left in the Third Party templates. Thanks also to @Muhamedkaif, whose #238 diagnosed this independently.🤖 Generated with Claude Code
feat: Third Party About page; About pages show product identity, not …