Add hovers for supertype methods in method call expressions#113
Open
trustytrojan wants to merge 3 commits into
Open
Add hovers for supertype methods in method call expressions#113trustytrojan wants to merge 3 commits into
trustytrojan wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Changes how method overloads are resolved from a MethodCallExpression so that inherited methods (from superclasses/interfaces) are considered, not just methods declared directly on the receiver's type.
Changes:
- Replaced
leftType.getMethods(name)with a filtered stream overgetAllDeclaredMethods()to include inherited methods.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add hovers for methods that belong to supertypes of an object within a method call expression.
Before the change, in the GIF below, there was no hover for
forEach.After the change:
