fix(timelapse): exclude linked component from Moonraker repo#34
Open
arlophoenix wants to merge 1 commit into
Open
fix(timelapse): exclude linked component from Moonraker repo#34arlophoenix wants to merge 1 commit into
arlophoenix wants to merge 1 commit into
Conversation
The Moonraker Timelapse installer symlinks its component into Moonraker's git repo at moonraker/components/timelapse.py. Because that file is not tracked by Moonraker's repository, update_manager permanently reports the repo as dirty: Repo has untracked source files: ['moonraker/components/timelapse.py'] This blocks clean update_manager status and can interfere with Moonraker updates, even though the component is intentional. Add the linked path to the repo's .git/info/exclude at install time (idempotent, guarded on .git/info existing) so update_manager stops flagging it. The uninstall path removes the exclude entry for symmetry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing Moonraker Timelapse symlinks its component into Moonraker's own git
repo at
moonraker/components/timelapse.py. Since Moonraker doesn't track thatfile,
update_managerthen permanently reports the repo as dirty —Repo has untracked source files: ['moonraker/components/timelapse.py']— whichclutters update status and can interfere with Moonraker updates, even though the
component is installed on purpose.
This adds the linked path to the Moonraker repo's
.git/info/excludeat installtime so
update_managerstops flagging it. The write is idempotent and guardedon
.git/infoexisting; the uninstall path removes the entry for symmetry. Therepo root and excluded path are derived from the existing
$TIMELAPSE_FILEvariable rather than hardcoded.
The same bug is inherited by the C0DEbrained Creality-Helper-Script-2025 fork,
which will benefit from this fix as well.
Test plan
sh -n scripts/moonraker_timelapse.shpassesupdate_managerno longer reports the untracked-source anomaly