Clarify nullability and documentation in AGENTS.md#6440
Conversation
…s for AI-modified code
There was a problem hiding this comment.
Code Review
This pull request updates AGENTS.md to clarify that nullability and documentation requirements apply only to code written or modified by AI. The review comments correctly identify an ambiguity in the phrasing of these exceptions, which could inadvertently exempt AI-modified existing files from compliance, and suggest clearer phrasing to specify that the exemption applies only to human-authored changes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| ## Nullability | ||
|
|
||
| These requirements apply only to code written or modified by AI. During code review, do not check changes to existing files for compliance with this section. |
There was a problem hiding this comment.
This phrasing introduces an ambiguity. The first sentence states that the requirements apply to code 'modified by AI'. However, the second sentence says 'do not check changes to existing files', which would technically exempt AI-modified existing files from being checked. Consider clarifying that this exemption applies specifically to human-authored changes.
| These requirements apply only to code written or modified by AI. During code review, do not check changes to existing files for compliance with this section. | |
| These requirements apply only to code written or modified by AI. Do not enforce these requirements on human-authored changes to existing files. |
|
|
||
| ## Documentation | ||
|
|
||
| These requirements apply only to code written or modified by AI. During code review, do not check changes to existing files for compliance with this section. |
There was a problem hiding this comment.
This phrasing introduces an ambiguity. The first sentence states that the requirements apply to code 'modified by AI'. However, the second sentence says 'do not check changes to existing files', which would technically exempt AI-modified existing files from being checked. Consider clarifying that this exemption applies specifically to human-authored changes.
| These requirements apply only to code written or modified by AI. During code review, do not check changes to existing files for compliance with this section. | |
| These requirements apply only to code written or modified by AI. Do not enforce these requirements on human-authored changes to existing files. |
…s for newly added Java source files
…ava source files and clarify documentation standards
…ewly added Java source files
No description provided.