Skip to content

Clarify nullability and documentation in AGENTS.md#6440

Merged
Glavo merged 5 commits into
HMCL-dev:mainfrom
Glavo:agents
Jul 19, 2026
Merged

Clarify nullability and documentation in AGENTS.md#6440
Glavo merged 5 commits into
HMCL-dev:mainfrom
Glavo:agents

Conversation

@Glavo

@Glavo Glavo commented Jul 19, 2026

Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added the 1+ label Jul 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates AGENTS.md to clarify that nullability and documentation requirements apply only to code written or modified by AI. The review comments correctly identify an ambiguity in the phrasing of these exceptions, which could inadvertently exempt AI-modified existing files from compliance, and suggest clearer phrasing to specify that the exemption applies only to human-authored changes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread AGENTS.md Outdated

## Nullability

These requirements apply only to code written or modified by AI. During code review, do not check changes to existing files for compliance with this section.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This phrasing introduces an ambiguity. The first sentence states that the requirements apply to code 'modified by AI'. However, the second sentence says 'do not check changes to existing files', which would technically exempt AI-modified existing files from being checked. Consider clarifying that this exemption applies specifically to human-authored changes.

Suggested change
These requirements apply only to code written or modified by AI. During code review, do not check changes to existing files for compliance with this section.
These requirements apply only to code written or modified by AI. Do not enforce these requirements on human-authored changes to existing files.

Comment thread AGENTS.md Outdated

## Documentation

These requirements apply only to code written or modified by AI. During code review, do not check changes to existing files for compliance with this section.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This phrasing introduces an ambiguity. The first sentence states that the requirements apply to code 'modified by AI'. However, the second sentence says 'do not check changes to existing files', which would technically exempt AI-modified existing files from being checked. Consider clarifying that this exemption applies specifically to human-authored changes.

Suggested change
These requirements apply only to code written or modified by AI. During code review, do not check changes to existing files for compliance with this section.
These requirements apply only to code written or modified by AI. Do not enforce these requirements on human-authored changes to existing files.

@Glavo
Glavo merged commit a34a743 into HMCL-dev:main Jul 19, 2026
1 check passed
@Glavo
Glavo deleted the agents branch July 19, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant