Feat/queue disc integration#22
Open
Vineet1101 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
…uler Introduce P4SwitchQueueItem as a concrete QueueDiscItem subclass that wraps post-pipeline Ethernet frames with egress port metadata. Integrate ns-3 QueueDisc into EventDrivenEgressDequeue: - If a QueueDisc is installed on a port, packets are buffered there after egress pipeline processing; TryTransmitFromQueueDisc() drains the QueueDisc onto the wire when the port is free. - If no QueueDisc is installed, the direct transmit path is taken (backwards-compatible with existing behavior). Fix critical control-flow bug: busy flag and PortTxComplete scheduling were previously unconditional, causing the port to deadlock when the QueueDisc path was taken. Update PortTxComplete to drain QueueDisc (priority 1) before checking the BMv2 egress_buffer (priority 2). Add SetPortQueueDisc() public API with auto-initialization following ns-3's TrafficControlLayer pattern. Remove dead output_buffer member references.
Contributor
|
Overall, the changes look fine to me. I still need to run more detailed tests locally, so you may wait until I finish the testing, and then we can summarize and address all comments together. I have two minor suggestions for now:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds support for queue-disc inside p4sim