Repository navigation
refactor: each observability service's config sits in a root folder named after it, out of backend/ - #454
Merged
Conversation
…amed after it, out of backend/ Grafana, Loki, OpenSearch, VictoriaMetrics and both collectors read their config through compose mounts; none of it is in the backend image. In backend/ a dashboard edit counted as a backend change and ran every CI job. The Grafana contract tests get their own job for backend and service config changes, and .trivyignore moves to the root since it covers both images.
HardMax71
enabled auto-merge (squash)
October 23, 2026 17:33
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
backend/ held the config of six other containers. None of it goes into the backend image, but CI's
backend/**filter counted a dashboard edit as a backend change: #431 changed one datasource line and ran 13 jobs, image builds and all E2E included.Changes
Each config moves with
git mvto a root folder named after its compose service (grafana/, host-metrics/, loki/, opensearch/, otel-collector/, victoria-metrics/), and .trivyignore to the root, since it covers both images. Mounts, the deploy's restart paths, the labeler and the docs follow. The contract test gets its own CI job, so a dashboard edit runs only that and the docs build.The first release recreates the six services and then restarts them once more. OpenSearch misses lines during both gaps; Loki keeps them.
Type of Change
Test Plan
cd backend && uv run pytest tests/unit)cd frontend && npm run test)docker compose exec -T backend sh -c 'uv sync --group test --no-dev --frozen --no-install-project --no-build && pytest tests/e2e')cd frontend && npm run test:e2e)./deploy.sh openapi, then./deploy.sh types), never edited by handValidation: the contract tests read all 13 dashboards, the alert rules and the collector config from the new paths and pass,
mkdocs build --strictpasses, and actionlint finds nothing new. The services started from the branch loaded their configs: 13 dashboards, 13 alert rules and 4 datasources in Grafana, OpenSearch's template and policy, Loki's 30-day retention, the VictoriaMetrics scrape job and 8 host series.Checklist
pre-commit run --all-filesand all checks passSummary by cubic
Moves each observability service's config out of
backend/into a root folder named after its compose service (grafana/,host-metrics/,loki/,opensearch/,otel-collector/,victoria-metrics/). A dashboard edit underbackend/previously counted as a backend change and ran every CI job, from image builds to all E2E; now it triggers only the docs build and the contract tests.backend/or a service config folder changes..trivyignoremoves to the repo root, since it covers both images.Deployment
Written for commit 62c779b. Summary will update on new commits.