Repository navigation
Conversation
…ctor Boxed_obj chose between registering a finaliser and doing nothing with std::is_destructible<T>, which is true for nearly every type. So values whose destructor does nothing, such as a struct of floats, were registered too. Each registration takes the finaliser lock and adds an entry to the global finaliser map, and every collection walks that map. The check is now is_destructible and not is_trivially_destructible. A trivially destructible value has no destructor to run, so nothing it needs is skipped. In an app that holds a matrix and a paint per visual this removed 43 to 45% of the live finaliser entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boxed_obj chose between registering a finaliser and doing nothing with std::is_destructible, which is true for nearly every type. So values whose destructor does nothing, such as a struct of floats, were registered too. Each registration takes the finaliser lock and adds an entry to the global finaliser map, and every collection walks that map.
The check is now is_destructible and not is_trivially_destructible. A trivially destructible value has no destructor to run, so nothing it needs is skipped.
In an app that holds a matrix and a paint (native cpp types wrapped in the new marshalling types) per visual (display object) this removed 43 to 45% of the live finaliser entries.