test(terminal): wait for startup endpoint before launch - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Codex hooks integration test fetches the printed launch URL before startup finishes writing endpoint.json. That can race the launch handler's endpoint update and leave the test with an unsuccessful launch response and no admin cookie.
Wait for the committed endpoint, as service and native clients do, and assert the launch response before using its cookies. This changes the test only; shipped extension and npm package bytes remain unchanged.
Validation: all seven terminal-host integration tests pass locally. The same product source already passed full release audits in both npm publication workflows; this removes a timing-dependent test entry point seen in the extension workflow.