🤖 Fix event products endpoint 500 response (TypeError)#1272
Open
Leonard013 wants to merge 1 commit into
Open
Conversation
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Fix Event Products endpoint 500 response
Description
This pull request resolves a 500 internal server error on the
/api/events/{event_id}/productsroute.Root Cause
In
GetProductsHandler::handle,$productPaginator->getCollection()returns a collection ofProductDomainObjects. However, this collection was passed directly to$this->productFilterService->filter(...).The
ProductFilterService::filtermethod expects a collection ofProductCategoryDomainObjects and processes it by calling$category->getProducts()inside aflatMapclosure. SinceProductDomainObjectdoes not implementgetProducts(), this mismatch triggers a PHP strict typingTypeError(or anErrorfor undefined method depending on configuration).Fix
ProductFilterServiceinto a new public methodfilterProducts(Collection $products, ...): Collection.ProductFilterService::filterto callfilterProductsinternally to avoid code duplication and preserve existing functionality for category-based filtering.GetProductsHandlerto invoke the newfilterProductsmethod on the retrievedProductDomainObjectcollection.backend/tests/Unit/Services/Application/Handlers/Product/GetProductsHandlerTest.phpthat verifies:TypeErrorinfilterunder the original implementation parameters.All backend unit tests pass successfully.
Closes #1268 🤖