Add generic ML-DSA KeyFactory and Signature - #1762
Merged
jasonkatonica merged 2 commits intoSep 10, 2026
Merged
Conversation
Register a family-level `ML-DSA` `KeyFactory` and `Signature` service so that callers can use the algorithm name `ML-DSA` without specifying a parameter set, matching the JEP 497 / JDK 24+ API contract. - Register `PQCKeyFactory$MLDSA` and `PQCSignatureImpl$MLDSA` as the `ML-DSA` service. Remove the `ML-DSA` alias from `ML-DSA-65` (it was a mis-mapping that silently directed all generic lookups to ML-DSA-65). - Split the single `name` field into `familyName` (returned by `getAlgorithm()` such as `ML-DSA`) and `paramSetName` (the concrete parameter set such as `ML-DSA-65`). Add getters and setters for these values such that other code can act accordingly. - Add tests to `BaseTestPQCKeyInterop`. These tests cover all three `ML-DSA` parameter sets via `@ParameterizedTest`. - Add tests to `BaseTestPQCKeys`. Expand alias coverage to include case variants, OID aliases, and bare OID strings. Added tests for `getAlgorithm()` family-name correctness for all ML-DSA and ML-KEM aliases - Add tests to `BaseTestPQCSignature` for generic `ML-DSA` sign/verify tests to all three parameter sets. Fixes: IBM#1567 Back-ported from: IBM#1667 Signed-off-by: Jason Katonica <katonica@us.ibm.com>
Signed-off-by: Jason Katonica <katonica@us.ibm.com>
jasonkatonica
requested review from
JinhangZhang,
KostasTsiounis,
johnpeck-us-ibm and
taoliult
September 10, 2026 14:15
taoliult
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register a family-level
ML-DSAKeyFactoryandSignatureservice sothat callers can use the algorithm name
ML-DSAwithout specifying aparameter set, matching the JEP 497 / JDK 24+ API contract.
PQCKeyFactory$MLDSAandPQCSignatureImpl$MLDSAas theML-DSAservice. Remove theML-DSAalias fromML-DSA-65(it was amis-mapping that silently directed all generic lookups to ML-DSA-65).
namefield intofamilyName(returned bygetAlgorithm()such asML-DSA) andparamSetName(the concreteparameter set such as
ML-DSA-65). Add getters and setters for thesevalues such that other code can act accordingly.
BaseTestPQCKeyInterop. These tests cover all threeML-DSAparameter sets via@ParameterizedTest.BaseTestPQCKeys. Expand alias coverage to include casevariants, OID aliases, and bare OID strings. Added tests for
getAlgorithm()family-name correctness for all ML-DSA and ML-KEMaliases
BaseTestPQCSignaturefor genericML-DSAsign/verifytests to all three parameter sets.
Fixes: #1567
Back-ported from: #1667
Signed-off-by: Jason Katonica katonica@us.ibm.com