Repository navigation
Conversation
chfsx
requested review from
dkippKPG,
dsstrassner,
kergomard,
maalers,
mbecker-databay,
mhomann-tf,
mjansenDatabay,
smeyer-ilias and
thibsy
October 23, 2026 20:06
This was referenced Oct 23, 2026
Contributor
|
@thojou please have also a Look for T&A! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local DICs of several components extended or instantiated
Pimple\Containerdirectly, and some code typed against it where the global$DICis meant. This PR introducesILIAS\DI\ServiceContaineras the one place that extends pimple, so the library can be updated or replaced in DI alone. Follow-up to #12266, which does the same forguzzlehttp/psr7in HTTP.DI
ILIAS\DI\ServiceContainer extends \Pimple\Container, without API of its own.ILIAS\DI\Container(the global$DIC) now extends it.ServiceContainerstill is aPimple\Container, so code outside of the core (e.g. plugins) typing against pimple keeps working.Components
ServiceContainerinstead ofPimple\Container: LearningSequence (ilLSDI,ilLSLocalDI), Test (TestDIC), TestQuestionPool (QuestionPoolDIC), ILIASObject and User (LocalDIC), WebDAV (ilWebDAVDIC), StudyProgramme (ilStudyProgrammeDIC), OrgUnit (ilOrgUnitLocalDIC), IndividualAssessment (ilIndividualAssessmentDIC) and the internal container ofInitComponentService.ServiceContainer(ilPrgUpdateProgressCronJob,ilObjIndividualAssessment, tests of Test).instanceofchecks that mean the global$DICchanged toILIAS\DI\Container(Test\GUIFactory,ilStudyProgrammeMembershipSourceReaderFactory,AllModernComponents,ilRbacSystem,ilLoggingErrorSettings). The global$DICis anILIAS\DI\Containereverywhere, also in all tests.Rendererand its expected results) still createsPimple\Containeron purpose: the generated bootstrap must not depend on the legacy DI component. Once [IMPROVEMENT] HTTP: keep guzzlehttp/psr7 inside the HTTP component #12266 is merged,pimple/pimplewill be added to theilias.wrappedLibraryUsagecode rule with DI and Component as its components.Testing
[OK] All static artifacts are build!, bootstrap artifacts fordefaultandsetuprebuilt.RootFolderTest, which only fails locally because of untracked files in the root folder of my checkout.components/ILIAS: green. php-cs-fixer on the changed files: clean.ilPrgUpdateProgressCronJobends withSTATUS_OK, and all entries of the local DICs of Test, TestQuestionPool, ILIASObject, User, StudyProgramme and OrgUnit resolve.DI has no maintainer at the moment. @kergomard @dsstrassner for Test/TestQuestionPool, ILIASObject, User and AccessControl, @dkippKPG for LearningSequence, @maalers @mhomann-tf for StudyProgramme/OrgUnit, @mbecker-databay for IndividualAssessment, @smeyer-ilias for Logging, @mjansenDatabay @thibsy for Init/Component.
If there are no objections, I will merge this before Coding Completed.