Change the requirement to display thumbnails from "thumbnailFile != null" to not useGenericThumbnail #12666 - #12667
Open
juancorr wants to merge 1 commit into
Open
Conversation
…ly when there is a thumbnail file in the dataset
qqmyers
approved these changes
Sep 3, 2026
|
|
||
| public String getThumbnailUrl() { | ||
| return thumbnailFile != null ? SystemConfig.getDataverseSiteUrlStatic() + "/api/datasets/" + this.getId() + "/logo" : null; | ||
| return !useGenericThumbnail ? SystemConfig.getDataverseSiteUrlStatic() + "/api/datasets/" + this.getId() + "/logo" : null; |
Member
There was a problem hiding this comment.
Looks good. I was wondering whether isPreviewImageAvailable() would be a better choice, but it looks like that is mostly kept in sych with useGenericThumbnail (i.e. they are opposites).
Member
There was a problem hiding this comment.
I'm requesting a review from @stevenwinship (no rush) because he most recently worked on this logic in the following PR:
pdurbin
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
stevenwinship
approved these changes
Sep 8, 2026
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
cmbz
added
FY27 Sprint 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#12666
Which issue(s) this PR closes:
Special notes for your reviewer:
Currently, a dataset thumbnail is only displayed if the dataset contains an image file, causing uploaded image files to be ignored. This PR updates the condition to display a thumbnail whenever an alternative to the default generic dataset thumbnail is available, restoring the behavior of Dataverse versions prior to v6.1.1.