Skip to content

Allows for the theming widget to style samples - #4015

Open
ChronosSF wants to merge 8 commits into
vnextfrom
sstoychev/react-theme-change
Open

ChronosSF wants to merge 8 commits into
vnextfrom
sstoychev/react-theme-change

Conversation

@ChronosSF

Copy link
Copy Markdown
Member

No description provided.

@ChronosSF

Copy link
Copy Markdown
Member Author

@copilot , the input - related changes are no longer okay, restore them so that the PR only includes the theme picker -related code.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The theme guard accepts inherited keys, and one live-editing configuration still references the deleted base component.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Centralizes runtime theme switching so documentation widgets can restyle embedded samples.

Changes:

  • Adds swappable prebuilt Ignite UI theme stylesheets.
  • Introduces ThemeService for theme messages, modes, and typefaces.
  • Removes legacy input-group theme handling.
File summaries
File Description
angular.json Copies prebuilt themes into assets.
src/index.html Adds the active theme link.
src/styles.scss Removes the compiled global theme.
src/app/app.component.ts Delegates theme messages to the service.
src/app/services/theme.service.ts Implements runtime theme switching.
src/app/data-entries/input-group/base-input.component.ts Removes legacy theme handling.
src/app/data-entries/input-group/input-group-sample-1/input-group-sample-1.component.ts Removes legacy base inheritance.
src/app/data-entries/input-group/input-group-sample-2/input-group-sample-2.component.ts Removes legacy base inheritance.
src/app/data-entries/input-group/input-group-sample-3/input-group-sample-3.component.ts Removes legacy base inheritance.
src/app/data-entries/input-group/input-group-sample-4/input-group-sample-4.component.ts Removes legacy base inheritance.
src/app/data-entries/input-group/input-group-sample-5/input-group-sample-5.component.ts Removes legacy base inheritance.
src/app/data-entries/input-group/input-group-sample-6/input-group-sample-6.component.ts Removes legacy base inheritance.
live-editing/configs/InputGroupConfigGenerator.ts Removes obsolete additional-file entries.
Review details

Suppressed comments (1)

src/app/data-entries/input-group/base-input.component.ts:1

  • Deleting this file leaves live-editing/configs/InputGroupConfigGenerator.ts:48 pointing to it in InputGroupStyleComponent's additionalFiles. That live-editing configuration will now request a file that no longer exists; remove the remaining entry as part of this deletion.
  • Files reviewed: 13/13 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/app/services/theme.service.ts Outdated
Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com>

Copilot AI commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@copilot , the input - related changes are no longer okay, restore them so that the PR only includes the theme picker -related code.

Restored the input samples, shared base component, and live-editing configuration in f4663ce. They now match vnext exactly, leaving only theme-picker-related changes in the PR. Review and CodeQL found no issues; local checks were blocked by missing dependencies.

Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com>

Copilot AI commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

🟡 Changes recommended

The theme guard accepts inherited keys, and one live-editing configuration still references the deleted base component....

Addressed the theme guard in 14f1f0f48. The live-editing concern was already resolved by f4663ceda, which restored the referenced base component, so no configuration change was needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants