Conversation
|
@copilot , the input - related changes are no longer okay, restore them so that the PR only includes the theme picker -related code. |
There was a problem hiding this comment.
🟡 Changes recommended
The theme guard accepts inherited keys, and one live-editing configuration still references the deleted base component.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Centralizes runtime theme switching so documentation widgets can restyle embedded samples.
Changes:
- Adds swappable prebuilt Ignite UI theme stylesheets.
- Introduces
ThemeServicefor theme messages, modes, and typefaces. - Removes legacy input-group theme handling.
File summaries
| File | Description |
|---|---|
angular.json |
Copies prebuilt themes into assets. |
src/index.html |
Adds the active theme link. |
src/styles.scss |
Removes the compiled global theme. |
src/app/app.component.ts |
Delegates theme messages to the service. |
src/app/services/theme.service.ts |
Implements runtime theme switching. |
src/app/data-entries/input-group/base-input.component.ts |
Removes legacy theme handling. |
src/app/data-entries/input-group/input-group-sample-1/input-group-sample-1.component.ts |
Removes legacy base inheritance. |
src/app/data-entries/input-group/input-group-sample-2/input-group-sample-2.component.ts |
Removes legacy base inheritance. |
src/app/data-entries/input-group/input-group-sample-3/input-group-sample-3.component.ts |
Removes legacy base inheritance. |
src/app/data-entries/input-group/input-group-sample-4/input-group-sample-4.component.ts |
Removes legacy base inheritance. |
src/app/data-entries/input-group/input-group-sample-5/input-group-sample-5.component.ts |
Removes legacy base inheritance. |
src/app/data-entries/input-group/input-group-sample-6/input-group-sample-6.component.ts |
Removes legacy base inheritance. |
live-editing/configs/InputGroupConfigGenerator.ts |
Removes obsolete additional-file entries. |
Review details
Suppressed comments (1)
src/app/data-entries/input-group/base-input.component.ts:1
- Deleting this file leaves
live-editing/configs/InputGroupConfigGenerator.ts:48pointing to it inInputGroupStyleComponent'sadditionalFiles. That live-editing configuration will now request a file that no longer exists; remove the remaining entry as part of this deletion.
- Files reviewed: 13/13 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com>
Restored the input samples, shared base component, and live-editing configuration in f4663ce. They now match |
Co-authored-by: ChronosSF <2188411+ChronosSF@users.noreply.github.com>
Addressed the theme guard in |
No description provided.