fix(grid): correct Excel filter virtual sizing - 21.2.x - #17526
Merged
Conversation
viktorkombov
requested review from
ChronosSF and
simeonoff
and
a lite review from Copilot
August 24, 2026 15:59
viktorkombov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Excel-style filtering virtualization sizing in Ignite UI for Angular grids by deriving the virtual item height from the first rendered list item, preventing scrollbar thumb lag and ensuring the last item remains reachable (notably in Indigo).
Changes:
- Initialize the Excel-style search virtual item size from a measured rendered list item height.
- Adjust Indigo/Fluent Excel-filtering styles to keep theme spacing aligned with virtualization sizing assumptions.
- Add/extend unit test coverage to verify the measured item size is applied to the virtualizer.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/virtual-for-directive/virtual-for.sample.html | Updates the virtualization sample markup to apply heights on the list-item host (supports consistent sizing behavior). |
| src/app/virtual-for-directive/virtual-for.sample.css | Ensures list item content fills the fixed-height host in the sample (height: 100%). |
| projects/igniteui-angular/grids/grid/src/grid-filtering-ui.spec.ts | Adds a unit test asserting rendered item height is propagated to the virtualizer item size and cache. |
| projects/igniteui-angular/grids/core/src/filtering/excel-style/excel-style-search.component.ts | Measures the first rendered Excel filter list item to stabilize itemSize used by the virtualizer. |
| projects/igniteui-angular/core/src/core/styles/components/grid/_excel-filtering-theme.scss | Adjusts Fluent/Indigo styling to keep spacing consistent with measured/virtualized item sizing. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
simeonoff
previously approved these changes
Aug 26, 2026
igdmdimitrov
added
✅ status: verified
ChronosSF
previously approved these changes
Sep 3, 2026
ChronosSF
enabled auto-merge (squash)
September 3, 2026 14:26
Update the expected rendered item counts after the Excel-style filter started using the actual measured row height. A 36px row height produces an eight-item virtual chunk for the 234px container, instead of the previous seven items based on the 40px fallback. Include the additional rendered value in the cascading-filter assertion.
viktorkombov
dismissed stale reviews from ChronosSF and simeonoff
via
September 3, 2026 15:53
58aa6c7
ChronosSF
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17513
Closes #17521
Description
Uses the first rendered Excel-style filter item to initialize the virtual item size. Theme-specific spacing is kept within the measured item, stabilizing the scrollbar and ensuring the last Indigo item is reachable.
Motivation / Context
The configured virtual item size could differ from the rendered height, causing scrollbar thumb lag. In the Indigo theme, the scroll range could also end before the last item was fully visible.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Added unit coverage verifying that the rendered item height is applied to the virtualizer. Manually verified the Indigo StackBlitz reproduction by dragging the scrollbar thumb to the bottom.
Test Configuration:
Screenshots / Recordings
See the recording attached to the related issue.
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdatesng updatemigrations for breaking changes (migrations guidelines)