fix(nav-drawer): preserve single-tap actions on iOS - 22.1.x - #17559
Open
viktorkombov wants to merge 6 commits into
Open
viktorkombov wants to merge 6 commits into
viktorkombov wants to merge 6 commits into
Conversation
viktorkombov
added
❌ status: awaiting-test
mddragnev
added
✅ status: verified
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The regression test checks an incorrect CSS class token, leaving part of its assertion ineffective.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR fixes iOS tap suppression by delaying Navigation Drawer pan recognition until meaningful horizontal movement.
Changes:
- Added configurable pan thresholds and axis filtering.
- Separated drawer gesture eligibility from pan recognition.
- Added touch-manager and Navigation Drawer regression tests.
File summaries
| File | Description |
|---|---|
navigation-drawer.component.ts |
Configures delayed horizontal gesture recognition. |
navigation-drawer.component.spec.ts |
Adds tap and gesture tests. |
core/src/core/touch.ts |
Implements pan thresholds, axis filtering, and cleanup. |
core/src/core/touch.spec.ts |
Tests gesture arbitration and state reset. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| document.body.dispatchEvent(touchMove); | ||
|
|
||
| expect((navDrawer as any)._panning).toBeFalse(); | ||
| expect(navDrawer.drawer.classList).not.toContain('panning'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17472
Description
Fixes an iOS regression where Navbar and icon-button actions could require two taps while Navigation Drawer gestures were enabled.
The Navigation Drawer now waits for meaningful horizontal movement before claiming the touch gesture and preventing native behavior. This preserves single-tap actions and vertical scrolling while keeping edge-swipe navigation working.
Implementation
The Navigation Drawer previously started tracking a pan immediately on
pointerdown. Its document-leveltouchmovelistener could consequently callpreventDefault()for the small involuntary movement produced during a tap. On iOS, this can suppress the compatibilityclick, making actions appear to require two taps.The fix separates gesture eligibility from gesture recognition:
pointerDownonly checks whether the gesture is eligible, such as starting inside the drawer edge zone.touchmoveis prevented only after the pan has been recognized.Testing
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)