Repository navigation
fix(grid): preselect custom conditions in Excel-style filtering (21.2.x) - #17787
viktorkombov wants to merge 3 commits into
Conversation
viktorkombov
added
🐛 bug
There was a problem hiding this comment.
🟢 Approval recommended
The localized fix preserves built-in fallback behavior, includes targeted regression coverage, and has no identified blocking issues.
0 open findings
What changed in this PR
Backports #17786 to 21.2.x, fixing custom-condition preselection in Excel-style filtering across Grid, Tree Grid, and Hierarchical Grid.
Changes:
- Resolves conditions from column filters before using built-in defaults.
- Adds three regression tests for custom conditions and fallback behavior.
- Documents the fix in the changelog.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/grid/src/grid-filtering-ui.spec.ts | Tests custom string/number preselection and built-in fallback. |
| projects/igniteui-angular/grids/core/src/filtering/excel-style/excel-style-custom-dialog.component.ts | Prioritizes column-defined filtering conditions. |
| CHANGELOG.md | Records the filtering fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
teodosiah
added
✅ status: verified
| - `IgxOverlayService` | ||
| - **Deprecation** - The `outlet` property in `OverlaySettings`, `IgxOverlayOutletDirective`, and `igxToggleOutlet` input on `IgxToggleActionDirective` are deprecated and will be removed in a future version. As overlay service now integrates the HTML Popover API and prefers rendering content in place / in the top layer, significantly reducing the need for outlet containers, new code should rely on the default in-place / top-layer rendering behavior instead of custom outlet containers. | ||
|
|
||
| ### Bug Fixes |
There was a problem hiding this comment.
Here the entry should be for 21.2.22, but I see the changelog is not updated properly for a long time now. Fix the changelog.
There was a problem hiding this comment.
Understood. I'll move this entry to 21.2.22. To confirm the scope, should I also backfill the missing patch release sections?
There was a problem hiding this comment.
Done, thanks! I backfilled the 21.2.1–21.2.22 sections from the release notes and moved this fix to 21.2.23, since 21.2.22 was already released with the dialog fix (#17757). I also added the two Copilot Skills groups that the 21.2.0 section on master already had.
Add the missing 21.2.1-21.2.22 sections from the release notes, move the Excel-style filtering fix to 21.2.23, and add the Copilot Skills entries that the 21.2.0 section on master already lists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes #17636
Description
Preselect custom conditions in the Excel-style filter dialog while preserving the built-in fallback.
Motivation / Context
Backport of #17786 to 21.2.x.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Grid, Tree Grid and Hierarchical Grid — Excel-style filtering.
How Has This Been Tested?
133 ESF tests passed, including three regressions.
npm run lint:libpassed.Test Configuration:
Screenshots / Recordings
N/A
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)