Repository navigation
fix(pivot-grid): span collapsed and summary row headers across columns - 21.2.x - #17849
Open
viktorkombov wants to merge 2 commits into
Open
viktorkombov wants to merge 2 commits into
viktorkombov wants to merge 2 commits into
Conversation
In the horizontal row layout, size collapsed and summary row headers to the combined width of the columns they span instead of the first one, and do not measure auto-sized dimensions again from them. Closes #17222 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
viktorkombov
added
❌ status: awaiting-test
viktorkombov
requested review from
teodosiah
and
a balanced review from Copilot
October 23, 2026 14:15
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow sizing fix matches the merged-cell width behavior and includes focused regression coverage, with no unresolved findings.
No open issues 🎉
What changed in this PR
Backports the pivot-grid header sizing fix from #17847 to 21.2.x, addressing #17222. Collapsed and summary headers in horizontal layouts now fill the columns they span.
Changes:
- Use the merged cell’s width for horizontal row headers.
- Skip dimensions with an existing automatic width to prevent unintended widening.
- Add regression tests and a 21.2.23 changelog entry.
| File | Description |
|---|---|
projects/igniteui-angular/grids/pivot-grid/src/pivot-row-dimension-header-group.component.ts |
Size horizontal headers using the parent cell’s full width. |
projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.spec.ts |
Test header spanning and automatic-width stability. |
projects/igniteui-angular/grids/pivot-grid/src/pivot-grid.component.ts |
Avoid recalculating already auto-sized dimensions. |
CHANGELOG.md |
Document the horizontal header sizing fix. |
Review effort: Balanced
Collapsed and summary row headers span several dimensions, but resizing changes only the first one, so measure that dimension for the resize line limits instead of the merged header. Closes #17222 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17222
Description
Backport of #17847 to 21.2.x.
In the horizontal row layout, collapsed row headers and summary (
Total) headers now fill all the columns they span. Before, they were only as wide as their first column.Motivation / Context
Regression from #16201 (20.1.0):
getHeaderWidthFromDimension()moved to the header group and returned its own column width (this.width) instead of the merged cell width (this.parent.width).autoSizeDimensionsInView()now skips dimensions that already have an auto width, so these wider headers do not widen them when it runs again. Resizing such a header changes only its first dimension, so the resize line limits are measured from that dimension.Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Pivot Grid
How Has This Been Tested?
The specs from #17847 fail on 21.2.x without the fix, and the pivot grid specs pass with it.
Test Configuration:
Screenshots / Recordings
The issue shows the actual and the expected result.
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)🤖 Generated with Claude Code