Conversation
Member
Author
|
@IMinchev64 , @Hristo313 , please go over the new topics that are already in vnext and add the theme picker where it makes sense. Check all themes and find the issues it might have. You need to use my PRs that add the request handler for all platforms except React where it's already merged. Consider these PRs to be still in test and to be merged after the samples show no defects with the theme picker. |
Member
Author
|
@Hristo313 , in Bootstrap Light the React sample overflows some internal boundary: 
|
Member
Author
|
Also there is a weird issue again in React: 
I think these borders might need more work to appear though. The inputs are a bit of a special case and we might need to disable the TP for them for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #836